fix: done called twice on invalid options #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CI with node version 10. The problem was that the steps in `afterStartOk` weren't aborted even though an error was detected and `bail` was called. Thus the callback was called at least twice.
kibertoad
approved these changes
Dec 28, 2021
|
appreciate the quick fix :) |
|
Sorry for the inconvenience and thank you for reviewing/merging =) |
This was referenced May 9, 2022
Merged
cressie176
pushed a commit
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI with node version 10.
The problem was that the steps in
afterStartOkweren't aborted even though an error was detected andbailwas called. Thus the callback was called at least twice.